Skip to content
Snippets Groups Projects
  1. Jun 20, 2014
  2. Jun 19, 2014
  3. Jun 15, 2014
  4. Jun 11, 2014
  5. Jun 04, 2014
  6. Jun 01, 2014
  7. May 31, 2014
  8. May 30, 2014
  9. Apr 18, 2014
  10. Mar 15, 2014
  11. Mar 12, 2014
    • W. Trevor King's avatar
      irkerd: Fix 'self.socket' -> 'socket' typos in _wrap_socket · 56d8dbd8
      W. Trevor King authored
      Respect the 'socket' argument passed in by the caller.  Fixes a typo
      introducted in a82724f9 (irkerd: Initial SSL/TLS implementation,
      2014-03-06).
      56d8dbd8
    • W. Trevor King's avatar
      irkerd: Fix -i / --immediate handling, and add a message argument · 35e07773
      W. Trevor King authored
      This fixes some problems with -i/--immediate parsing in ccd311c5
      (irkerd: Transition from getopt to argparse, 2014-03-06).
      
      > +    parser.add_argument(
      > +        '-i', '--immediate', action='store_const', const=True,
      > +        help='disconnect after sending each message')
      
      This does not match the old syntax where -i took two arguments (an IRC
      URL and a message).
      
      > -    if immediate:
      > +    if args.immediate:
      >          irker.irc.add_event_handler("quit", lambda _c, _e: sys.exit(0))
      >          irker.handle('{"to":"%s","privmsg":"%s"}' % (immediate, arguments[0]), quit_after=True)
      >          irker.irc.spin()
      
      immediate should be args.immediate, and arguments[0] needs to be added
      as a new (optional) positional argument.
      
      This patch fixes both issues.
      35e07773
    • Eric S. Raymond's avatar
      cc0c6358
  12. Mar 11, 2014
    • Eric S. Raymond's avatar
      Allow kwargs use. · 0449c058
      Eric S. Raymond authored
      0449c058
    • Eric S. Raymond's avatar
      Documentation updates. · 068053b5
      Eric S. Raymond authored
      068053b5
    • W. Trevor King's avatar
      irkerd: Extract username and password from submitted URLs · abed95e1
      W. Trevor King authored
      And use them (when present) as the USER username [1] and server PASS
      [2] respectively.  The previous implementation gave no way to set
      PASS, which will vary on a per-target-server level.  There's unlikely
      to be much need to set per-server usernames, except collision
      avoidance (e.g. network X already has an 'irker' user).
      
      I changed the existing IRCServerConnection.connect argument from
      'ircname' to 'realname' to match the USER specs and our
      IRCServerConnection.user implementation.  The 'realname' and
      'username' arguments are currently unset, but you could add command
      line options to set irker-wide defaults, and use the kwargs chain to
      pass them down to the connect method.  The fallback logic is:
      
      * Prefer the setting listed in the URL (although you'd need to add a
        parser to extract 'realname').  If that's empty or missing, fall
        back to
      * The irker-wide default passed down the kwargs chain.  If that's
        empty or missing, fall back to
      * Local defaults ('irker' and 'irker relaying client').
      
      I also tweaked the servername and port extraction in
      Target.__init__(), because they are already parsed out of the netloc
      (along with the username and password) by urlparse().
      
      [1]: https://tools.ietf.org/html/rfc2812#section-3.1.3
      [2]: https://tools.ietf.org/html/rfc2812#section-3.1.1
      abed95e1
Loading