Skip to content
Snippets Groups Projects
  1. May 17, 2013
  2. May 15, 2013
  3. May 05, 2013
  4. Apr 24, 2013
  5. Apr 17, 2013
  6. Apr 16, 2013
  7. Feb 22, 2013
  8. Feb 03, 2013
  9. Jan 25, 2013
  10. Jan 09, 2013
    • Bernhard Reutner-Fischer's avatar
      irkerhook: Fix handling of non-ascii author name · f6fbbca0
      Bernhard Reutner-Fischer authored
      
      Signed-off-by: default avatarBernhard Reutner-Fischer <rep.dot.nop@gmail.com>
      
      ---
      for non-ascii input, irkerhook.py dies with:
      
      remote: Traceback (most recent call last):
      remote:   File "/usr/bin/irkerhook.py", line 484, in <module>
      remote:     ship(extractor, commit, not notify)
      remote:   File "/usr/bin/irkerhook.py", line 391, in ship
      remote:     metadata = extractor.commit_factory(commit)
      remote:   File "/usr/bin/irkerhook.py", line 262, in commit_factory
      remote:     metainfo = do("git log -1 '--pretty=format:%an <%ae>|%s' " +
      shellquote(commit.commit))
      remote:   File "/usr/bin/irkerhook.py", line 50, in do
      remote:     return unicode(commands.getstatusoutput(command)[1],
      locale.getpreferredencoding() or 'UTF-8')
      remote: UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in
      position 8: ordinal not in range(128)
      
      for e.g. this author name:
      $ git log -n1 --pretty="format:%an" | cat;echo
      Timo Teräs
      $ git log -n1 --pretty="format:%an" | od -x;echo
      0000000 6954 6f6d 5420 7265 a4c3 0073
      0000013
      So:
      $ for i in C POSIX en_US.UTF-8;do echo "# $i";LC_ALL=$i python -c
      "import locale;print locale.getlocale()[1];print unicode(\"ä\",
      locale.getlocale()[1] or 'UTF-8').encode(locale.getlocale()[1] or
      'UTF-8')";done
      None
      ä
      None
      ä
      None
      ä
      f6fbbca0
  11. Dec 09, 2012
  12. Nov 26, 2012
Loading